Change to F5 runners for release builds #1162
Conversation
|
Hi @AlexFenlon! Welcome to the project! 🎉 Thanks for opening this pull request! |
There was a problem hiding this comment.
Pull Request Overview
This PR restructures the release workflow by creating a separate manually-triggered release workflow while maintaining the CI workflow for continuous builds. The changes enable F5-specific infrastructure (runners and Artifactory) for releases while ensuring CI builds work for both internal and forked repositories. Package distribution configurations (Homebrew, Nix, Scoop) that were previously commented out have been re-enabled for releases, and Snapcraft support has been removed.
Key Changes
- Created a new manually-triggered release workflow (
release.yml) that uses F5 infrastructure (F5 runners, Artifactory proxy) and publishes to package managers - Modified CI workflow to run builds without releases, using conditional runners (standard for PRs, F5 for main branch) and Artifactory proxy selection based on workflow context
- Added assertion document generation job to both workflows for compliance tracking
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.goreleaser.yml |
Re-enabled Homebrew, Nix, and Scoop distribution configurations; removed Snapcraft and previously commented brew sections |
.github/workflows/release.yml |
New workflow for manual releases with F5 infrastructure, package distribution, and assertion document generation |
.github/workflows/ci.yml |
Updated to remove tag-based releases, add conditional runner selection, Artifactory proxy configuration, and assertion document generation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
github-project-automation
bot
moved this from In Review 👀
to Done 🚀
in NGINX Ingress Controller
3 participants
Proposed changes
Checklist
Before creating a PR, run through this checklist and mark each as complete.